Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported resources #1402

Merged
merged 6 commits into from
Mar 12, 2024
Merged

Conversation

danielrbradley
Copy link
Member

Use the same schema for the SDK and docs:

  • Switch to using pulumi package gen-sdk.
    • Remove unused language-specific code from the gen binary.
  • Generate a single schema - just what we use in the docs:
    • Exclude unsupported resources.
    • Include examples in descriptions.
  • Always clean SDK directory before generation to avoid left-over files.

Generate SDKs:

  • Warning text changes in all files.
  • Resource descriptions include examples.
  • Unsupported resources are removed.
  • Remove obsolete cf2pulumi full schema as we only use the uncommitted compressed schemas now.

- Switch to using `pulumi package gen-sdk`.
  - Remove unused language-specific code from the gen binary.
- Generate a single schema - just what we use in the docs:
  - Exclude unsupported resources.
  - Include examples in descriptions.
- Always clean SDK directory before generation to avoid left-over files.
- Warning text changes in all files.
- Resource descriptions include examples.
- Unsupported resources are removed.
- Remove obsolete cf2pulumi full schema as we only use the uncommitted compressed schemas now.
Copy link
Contributor

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 59 lines in your changes are missing coverage. Please review.

Project coverage is 23.58%. Comparing base (dce8812) to head (0f7a065).

Files Patch % Lines
provider/cmd/pulumi-gen-aws-native/main.go 0.00% 45 Missing ⚠️
provider/cmd/pulumi-gen-aws-native/examples.go 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1402      +/-   ##
==========================================
+ Coverage   23.39%   23.58%   +0.18%     
==========================================
  Files          25       25              
  Lines        4244     4211      -33     
==========================================
  Hits          993      993              
+ Misses       3088     3055      -33     
  Partials      163      163              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielrbradley danielrbradley added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Mar 11, 2024
Copy link
Member

@mikhailshilkov mikhailshilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

provider/cmd/pulumi-gen-aws-native/main.go Outdated Show resolved Hide resolved
- Improve error handling.
- Rename "language" to "operation".
@danielrbradley danielrbradley enabled auto-merge (squash) March 12, 2024 08:53
@danielrbradley danielrbradley merged commit d10d29a into master Mar 12, 2024
16 of 17 checks passed
@danielrbradley danielrbradley deleted the remove-unsupported-resources branch March 12, 2024 09:10
danielrbradley added a commit that referenced this pull request Mar 14, 2024
Fix regression in makefile where we expect local_generate to include the
schema generation step but had lost it during refactoring in
#1402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants