-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unsupported resources #1402
Conversation
- Switch to using `pulumi package gen-sdk`. - Remove unused language-specific code from the gen binary. - Generate a single schema - just what we use in the docs: - Exclude unsupported resources. - Include examples in descriptions. - Always clean SDK directory before generation to avoid left-over files.
- Warning text changes in all files. - Resource descriptions include examples. - Unsupported resources are removed. - Remove obsolete cf2pulumi full schema as we only use the uncommitted compressed schemas now.
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1402 +/- ##
==========================================
+ Coverage 23.39% 23.58% +0.18%
==========================================
Files 25 25
Lines 4244 4211 -33
==========================================
Hits 993 993
+ Misses 3088 3055 -33
Partials 163 163 ☔ View full report in Codecov by Sentry. |
Mirror the change from pulumi/pulumi-azure-native#3135
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
- Improve error handling. - Rename "language" to "operation".
Fix regression in makefile where we expect local_generate to include the schema generation step but had lost it during refactoring in #1402
Use the same schema for the SDK and docs:
pulumi package gen-sdk
.Generate SDKs: